[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
(usagi-users 03338) Re: netfilter6: ICMPv6 type 143 doesn't match
- To: kaber@xxxxxxxxx (Patrick McHardy)
- Subject: (usagi-users 03338) Re: netfilter6: ICMPv6 type 143 doesn't match
- From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
- Date: Fri, 06 May 2005 23:22:42 +1000
- Cc: davem@xxxxxxxxxxxxx, dlstevens@xxxxxxxxxx, laforge@xxxxxxxxxxxx, netdev@xxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxxxxxx, pb@xxxxxxxxxxxx, usagi-users@xxxxxxxxxxxxxx, yasuyuki.kozakai@xxxxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx
- In-reply-to: <427AA319.1040906@trash.net>
- Organization: Core
- Reply-to: usagi-users@xxxxxxxxxxxxxx
- Resent-date: Sat, 7 May 2005 12:12:02 +0900
- Resent-from: yoshfuji@xxxxxxxxxxxxxx
- Resent-message-id: <200505071212.FMLAAB534.usagi-users@linux-ipv6.org>
- Resent-to: usagi-users@xxxxxxxxxxxxxx (moderated)
- User-agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.27-hx-1-686-smp (i686))
Patrick McHardy <kaber@xxxxxxxxx> wrote:
>
> +static inline int mld_dev_queue_xmit2(struct sk_buff *skb)
> +{
> + struct net_device *dev = skb->dev;
> +
> + if (dev->hard_header) {
> + unsigned char ha[MAX_ADDR_LEN];
> + int err;
> +
> + ndisc_mc_map(&skb->nh.ipv6h->daddr, ha, dev, 1);
> + err = dev->hard_header(skb, dev, ETH_P_IPV6, ha, NULL, skb->len);
> + if (err < 0) {
> + IP6_INC_STATS(IPSTATS_MIB_OUTDISCARDS);
You're now incrementing this twice since the callers will also
increment this.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt